Skip to content

Clean up standalone imports in tests #31772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 26, 2025
Merged

Clean up standalone imports in tests #31772

merged 18 commits into from
Aug 26, 2025
+23 −520

Conversation

crisbeto
Copy link
Member

Most of the imports in our tests aren't necessary anymore after we switched everything over to standalone. These changes clean up all the usages.

@crisbeto crisbeto requested a review from a team as a code owner August 23, 2025 07:39
@crisbeto crisbeto requested review from andrewseguin and wagnermaciel and removed request for a team August 23, 2025 07:39
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release merge: preserve commits When the PR is merged, a rebase and merge should be performed labels Aug 23, 2025
@crisbeto crisbeto removed the request for review from wagnermaciel August 25, 2025 20:11
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: major This PR is targeted for the next major release labels Aug 25, 2025
@crisbeto crisbeto force-pushed the full-standalone-import-cleanup branch from 046a882 to 2e84514 Compare August 25, 2025 20:13
@crisbeto crisbeto mentioned this pull request Aug 25, 2025
Merged
crisbeto added 18 commits August 26, 2025 07:29
@crisbeto
test(material/datepicker): clean up unnecessary imports in tests
bf2e6d0 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/divider): clean up unnecessary imports in tests
9f40d5e 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/expansion): clean up unnecessary imports in tests
f7eeecd 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/form-field): clean up unnecessary imports in tests
e4d2ebd 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/menu): clean up unnecessary imports in tests
192f071 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/list): clean up unnecessary imports in tests
4dbe164 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/progress-bar): clean up unnecessary imports in tests
414290c 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/progress-spinner): clean up unnecessary imports in tests
caaf4cb 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/radio): clean up unnecessary imports in tests
f6e8dc4 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/sidenav): clean up unnecessary imports in tests
70f6238 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/slide-toggle): clean up unnecessary imports in tests
ead30fe 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/snack-bar): clean up unnecessary imports in tests
14d397b 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/sort): clean up unnecessary imports in tests
67afd7a 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/table): clean up unnecessary imports in tests
8ee5d3c 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/tabs): clean up unnecessary imports in tests
95c7ae9 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/toolbar): clean up unnecessary imports in tests
80ffba4 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/tooltip): clean up unnecessary imports in tests
eb6b8d4 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto
test(material/tree): clean up unnecessary imports in tests
498f1f6 
Removes imports from tests that aren't necessary anymore, because we're using standalone.
@crisbeto crisbeto force-pushed the full-standalone-import-cleanup branch from 2e84514 to 498f1f6 Compare August 26, 2025 05:30
@crisbeto crisbeto merged commit b9d5a95 into angular:main Aug 26, 2025
20 of 22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adolgachev adolgachev adolgachev approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/a11y area: cdk/clipboard area: cdk/menu area: cdk/observers area: cdk/scrolling area: cdk/table area: cdk/text-field area: material/badge area: material/bottom-sheet area: material/button area: material/button-toggle area: material/card area: material/checkbox area: material/chips area: material/core area: material/datepicker area: material/dialog area: material/divider area: material/expansion area: material/form-field area: material/grid-list area: material/icon area: material/list area: material/menu area: material/progress-bar area: material/progress-spinner area: material/radio area: material/sidenav area: material/slide-toggle area: material/slider area: material/snack-bar area: material/sort area: material/table area: material/tabs area: material/toolbar area: material/tooltip area: material/tree merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @adolgachev